search

dblock / obcd

Deal with obsessive compulsive issues of programmers in Objective-C.
MIT License
42 stars 8 forks source link

Added a SpectaFocus check for finding focused specs #15

Closed wessmith closed 10 years ago

wessmith commented 10 years ago

related issue #14 /cc @orta

wessmith commented 10 years ago

This is my first foray into ruby so do let me know if there's anything that could be done better or that is not the typical way of doing something, etc. I would be most appreciative since I'm learning as I go here.

Also note that the output of $ obcd find --help is as follows:

Note: the unbroken line in Available checks:

NAME
    find - Find files that don't match rules.

SYNOPSIS
    obcd [global options] find check, check[, check]*

DESCRIPTION
    Available checks:

    - HeaderStyle: Normalize header style on top of .m and .h files. - SpectaFocus: Detect instances of focused specs.

I'm not sure why that's happening since obcd/bin/obcd:20 has the .join("\n")

long_desc "Available checks:\n\n" + Obcd::Checks.all.map { |check|
  "- #{check.name.split('::').last}: #{check.desc}"
}.join("\n")
wessmith commented 10 years ago

Looks like Travis failed on the spec displays a list of checks which is what I commented on above

Interestingly, when I run bundle exec rake locally all the specs pass.

dblock commented 10 years ago

This is great! There's a failed test in Travis, check it out pls.

dblock commented 10 years ago

Merged via https://github.com/dblock/obcd/commit/f08dd3e7cb68f0763f63b3df07cace2232325daa. I think the spec failure is something weird in the output of gli, the command line thing. I cannot see the failure locally, but my text is mangled like on Travis. I made it a double \n and it seems better.