search

dblock / ruby-enum

A handy way to define enums in Ruby.
MIT License
177 stars 23 forks source link

Add modern Rubies to CI. Fix unquoted 3.0. Update gems. Set minimum version to 2.7 #39

Closed petergoldstein closed 1 year ago

petergoldstein commented 1 year ago

This PR is designed to bring this repo up to date with regard to supported Rubies (adding both 3.1 and 3.2)

Given the difficulty in supporting wide ranges of Ruby versions, especially when Rubocop is running, I updated the minimum Ruby version to 2.7.

petergoldstein commented 1 year ago

Thanks!!!

Get a new danger token from https://github.com/slack-ruby/slack-ruby-client/blob/master/.github/workflows/pr_lint.yml#L20. Update it, make sure it works.

Update CHANGELOG with minimum version required.

Done.

petergoldstein commented 1 year ago

Get a new danger token from https://github.com/slack-ruby/slack-ruby-client/blob/master/.github/workflows/pr_lint.yml#L20. Update it, make sure it works.

I take that back. Didn't work. This is the same token on https://github.com/hashie/hashie/blob/master/.github/workflows/danger.yml . Any idea where I can get a working token @dblock ?

dblock commented 1 year ago

Get a new danger token from https://github.com/slack-ruby/slack-ruby-client/blob/master/.github/workflows/pr_lint.yml#L20. Update it, make sure it works.

I take that back. Didn't work. This is the same token on https://github.com/hashie/hashie/blob/master/.github/workflows/danger.yml . Any idea where I can get a working token @dblock ?

The problem is something else - upgrade danger to the latest?

petergoldstein commented 1 year ago

@dblock Danger is already latest.

dblock commented 1 year ago

@petergoldstein I know what the problem is, you need to change fetch-depth like here. I'd just split these YMLs.

petergoldstein commented 1 year ago

@dblock Let me know if this works.

dblock commented 1 year ago

~Let's increment version to 1.0 (it's pretty mature I suppose, and time to start following major semver) as part of this PR and fix danger?~

dblock commented 1 year ago

I merged this thank you!

Want to help me co-maintain this library? Email me your rubygems login to dblock at dblock dot org. Let's increment the version to 1.0 and make a release?