search

dblock / slack-gamebot

Ping pong, chess, pool and other games bot for Slack.
MIT License
129 stars 103 forks source link

Add taunt command so players can taunt each other. #153

Closed marin-hyatt closed 6 years ago

marin-hyatt commented 7 years ago

When a player enters "@pongbot taunt @playername", the bot will announce that @playername sucks at ping pong. Example:

@pongbot taunt @player2

@player1 said @player2 sucks at ping pong!

dblock commented 7 years ago

For CI failures run rubocop -a ; rubocop --auto-gen-config and make sure rake succeeds locally.

marin-hyatt commented 6 years ago

It's been a while since I committed this. As far as I know, all the checks have passed, and the test works. Is there anything else I need to do to make this better?

dblock commented 6 years ago

You still need to update https://github.com/dblock/slack-gamebot/blob/master/CHANGELOG.md and https://github.com/dblock/slack-gamebot/blob/master/slack-gamebot/commands/help.rb, but I think that's mostly it after that. I did make some more code comments that you should address.

marin-hyatt commented 6 years ago

I think I fixed all the problems you pointed out and also updated everything you asked me to. If you could look over this it would be great.

dblock commented 6 years ago

Doesn't look like it. For one a bunch of my comments are still visible and this PR says there's a conflict in CHANGELOG.md. I think you need to push your changes up here (possibly force push with -f).

marin-hyatt commented 6 years ago

I made some commits so that taunt and taunt.spec pass all the tests, but the CI build still fails. It isn't failing because of my tests because it was failing before (without my command added), so I think that shouldn't be a problem for my commit.

dblock commented 6 years ago

Merged via https://github.com/dblock/slack-gamebot/commit/d46c7f1bf8bf9c9b76ec7eefa4762e9ceedb6398, thanks for hanging in here! Will get deployed soon.