dblock / slack-gamebot

Ping pong, chess, pool and other games bot for Slack.
MIT License
129 stars 103 forks source link

Remove players #86

Closed eneko closed 8 years ago

eneko commented 8 years ago

Ability to remove players that no longer want to play or no longer work at the company.

dblock commented 8 years ago

:+1:

Want to try to implement this @eneko or I can prioritize this if http://playplay.io/#sponsors ;)

eneko commented 8 years ago

I could give it a try, but haven't set up a dev environment yet. Will try.

dblock commented 8 years ago

I think we want captains to be able to unregister @name and players to do unregister themselves. That shouldn't delete the user record though, that would break seasons history, existing challenges, etc, but probably mark the user deleted and show <deleted> in history or stats. Captains shouldn't be able to unregister themselves, but would be required to step down first.

eneko commented 8 years ago

Makes sense. I think the removed users should no longer appear on leaderboards, but it would be good to keep them on the matches history.

dblock commented 8 years ago

I've implemented unregister in https://github.com/dblock/slack-gamebot/commit/d3379293f0c502fd97598efc680ed68d5ad5639c. It will make its way to playplay.io in the next 24 hours. It removes someone from the leaderboard and from the ability to play, but doesn't purge them from match history or anything. Users can re-activate themselves. Suggestions of whether we need to do more, welcome!

dblock commented 8 years ago

Deployed.

https://twitter.com/playplayio/status/753954352511844353

screen shot 2016-07-15 at 10 06 23 am