search

dblock / slack-market

Market quotes in Slack.
Other
32 stars 17 forks source link

Changing graphs doesn't change quotes #29

Open dblock opened 8 years ago

dblock commented 8 years ago

When switching between graphs, the quoted % doesn't change. It should also adjust the change_in_percent.

/cc: @ddruker

ddruker commented 8 years ago

@dblock Understood. I can look into this.

ddruker commented 8 years ago

Hey @dblock, Let's use the 1y chart as an example. So you would like the percent change between the closing price of the stock for the same day last year and the current value or closing price for the day?

dblock commented 8 years ago

Exactly.

dblock commented 8 years ago

Also, https://twitter.com/dblockdotorg/status/749599512847650816.

dblock commented 8 years ago

I noticed Yahoo doesn't change those quotes when you change the graphs btw, so maybe I am missing something or maybe we want both?

ddruker commented 8 years ago

Hey, do you mean the Yahoo web app?

Yahoo doesn't show that specific percentage in their own app. I can implement it by making a request to query historical data and just calculate the change in percent. Thoughts?

In my opinion, we should always keep the current stock's value and the current percent change for the day visible to the User.

This is another PR but I can add in a feature that shows the stock's highs and lows for 1d, 1m and 1y intervals.

On Jul 4, 2016, at 3:23 PM, Daniel Doubrovkine (dB.) @dblockdotorg notifications@github.com wrote:

I noticed Yahoo doesn't change those quotes when you change the graphs btw, so maybe I am missing something or maybe we want both?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

dblock commented 8 years ago

I don't have any strong opinions, initially it was confusing that when I clicked 1Y I saw the % that wasn't 1Y, but I agree that everybody is doing it.

dblock commented 8 years ago

Maybe it could say those numbers in "below is the 1y chart", so "Below is the 1 year chart (+2.34%)"?

ddruker commented 8 years ago

Hey @dblock, Yeah I think it could be in that String containing the percent change between the closing value of the stock one year before. Same for 1m etc.