dblock / slack-strava

(Re)Post Strava activities to Slack
https://slava.playplay.io
MIT License
37 stars 6 forks source link

Extend set sync to turn syncing on/off for a user per channel #129

Open laurelstreng opened 2 years ago

laurelstreng commented 2 years ago
dblock commented 2 years ago

Do I read this correctly that you expected only a certain type of workout in the channel? Could you please post some examples of what is showing up (maybe screenshots) that you don't expect to see?

laurelstreng commented 2 years ago

@dblock so yes, I expected that if I connected a Strava Club to a channel that it would only post the workouts from the Club (in this case it's a Running specific club).

An example of what i'm seeing is that any type of workout from members in the Strava Club are appearing in the channel. In this screenshot there is a Stand Up Paddle Boarding working that posted from myself: Screen Shot 2022-05-16 at 9 46 28 AM

laurelstreng commented 2 years ago

Additional note: Members of this running Slack channel did connect their individual Strava accounts to Slava. Is that possibly why all different types of workouts are appearing in the running Slack channel?

Maybe we're just using it wrong?

dblock commented 2 years ago

Additional note: Members of this running Slack channel did connect their individual Strava accounts to Slava. Is that possibly why all different types of workouts are appearing in the running Slack channel?

That's why. Slava is smart enough to reconcile two activities as duplicates and only post it once (the user's) but it's also sending your activities for the ride. Instead of disconnecting, right now you can only disable your own sync with set sync false. Unfortunately that will disable your sync globally, there's no way to do it just in this one channel.

We thus have a few feature requests.

Currently the code checks whether the user is in-channel to notify about an activity here. It would need to get smarter and allow users to enable sync not just globally but per-channel.

Does it make sense? Want to try and implement it? :)

laurelstreng commented 2 years ago

@dblock the set sync false definitely worked, thanks for all this!