dblock / slack-strava

(Re)Post Strava activities to Slack
https://slava.playplay.io
MIT License
37 stars 6 forks source link

Swim in meters #39

Closed gmiossec29 closed 6 years ago

gmiossec29 commented 6 years ago

Even with units settings in kilometer, swim activities were displayed in yards

dblock commented 6 years ago

Amazing! Thank you.

dblock commented 6 years ago

Btw those user tests aren’t failing for me either way, so probably order dependent. The find method gets a user from the database and then does user info from slack to update the data. The (more) correct fix is to make the username something like “whatever” so that it doesn’t ever find an existing record, and creates a new one. I’ll take care of it later ...

dblock commented 6 years ago

I don’t have computer access today (traveling) but will deploy this tomorrow.

gmiossec29 commented 6 years ago

You are welcome !

dblock commented 6 years ago

Are you using the bot? I’ll subscribe you for free if you want (what’s your team ID?).

gmiossec29 commented 6 years ago

Yes, we are using the bot on a shared slack : velochinois.slack.com Thanks you very much for your offer ! Our team ID is T8UBG68RZ. If I can I would be happy to contribute again to your project !

dblock commented 6 years ago

Upgraded, this won't expire. Don't hesitate to donate to TeamForKids if you find the bot useful and thanks for contributing code!

gmiossec29 commented 6 years ago

Thank you very much !