search

dblock / slack-strava

(Re)Post Strava activities to Slack
https://slava.playplay.io
MIT License
37 stars 6 forks source link

Toggle pace to speed #43

Open dblock opened 6 years ago

dblock commented 6 years ago

That would be more useful for biking.

dblock commented 6 years ago

I added displaying both pace and speed in https://github.com/dblock/slack-strava/commit/d1b0fecd7f7990fc14bd98b99310d0c2b9a64693 and you can now configure which fields to display with set fields. I wonder whether we should choose automatically whether to display pace vs. speed by default depending on the type of activity?

imjared commented 7 months ago

We just started running this app and I was surprised to see pace for my morning ride. Probably could show one or the other depending on ride vs run.

dblock commented 7 months ago

@imjared Yes, I would make the change in https://github.com/dblock/slack-strava/blob/master/slack-strava/models/activity_methods.rb#L305. Want to try to contribute?

imjared commented 7 months ago

For sure, thanks for pointing me to it. Probably not going to be a quick turnaround but I'll shoot a PR your way before too long.