search

dblock / slack-sup

Slack bot that generates fresh triads of team members to meet every week in an informal standup, or S'Up.
https://sup.playplay.io/
Other
19 stars 10 forks source link

Configurable followup day #48

Closed ashkan18 closed 7 years ago

ashkan18 commented 7 years ago

Problem

Currently follow up message is hardcoded to be sent on every Thursday, we need to make it configurable.

fixes https://github.com/dblock/slack-sup/issues/44

Solution

Followed the same pattern as sup_wday, added a new sup_followup_wday field to Team which by default is set to 4 (Thursdays). Added new set followup command which can set sup_followup_wday for the team by admin.

Question

wasn't sure if we want any type of validation on sup_followup_wday originally i thought it should be after sup_wday but that doesn't make sense if we want to send sup message on Thursday and followup on Monday for example. Let me know what you think.

dblock commented 7 years ago

Great stuff. Need to update help as well I believe and rebase.

dblock commented 7 years ago

Merged. Note that this doesn't allow you to say "do a sup on Monday once a month, then ask about it two weeks later", but I am not sure we want to support that prematurely.

ashkan18 commented 7 years ago

👍 Do we need migration for existing teams? or Mongoid default does it for us?

dblock commented 7 years ago

I am pretty sure default does it.

dblock commented 7 years ago

FYI this was deployed to https://sup.playplay.io/

ashkan18 commented 7 years ago

awesome! thanks! 🙌

dblock commented 7 years ago

This broke something and fixed in https://github.com/dblock/slack-sup/commit/d463ffa79a2789f954d2d9c65909b60870c8340f.

You should generally also run the bot locally, the contributing doc tells you how to set it up (or should), catches paths like these.

ashkan18 commented 7 years ago

good point! sorry about that, sure i was wondering how can i do end-to-end test locally. Will try it next time.

dblock commented 7 years ago

Instructions in https://github.com/dblock/slack-sup/blob/master/DEV.md