Make browser launch platform-independent

dblock / strava-ruby-cli

Strava command-line client.

MIT License

5 stars 1 forks source link

Make browser launch platform-independent #2

Closed mattdsteele closed 4 years ago

mattdsteele commented 4 years ago

Fixes #1

I was able to build and install it locally and it appears to work on both vanilla Linux and WSL, but this probably needs a second set of eyes. I'm not very familiar with Gem packaging, so let me know if anything needs changed. I couldn't get specs to run; it timed out for me for some reason.

As info, there's still a workaround required for WSL: https://github.com/copiousfreetime/launchy/issues/117#issuecomment-363277558

dblock commented 4 years ago

Thanks, merged.

Is there an error when the browser fails to launch (e.g. without $BROWSER), or do we get a hang again? Want to check out https://github.com/dblock/strava-ruby-cli/issues/3?