Fixing Stravas faulty start_date_local implementation

simonneutert commented 3 years ago

@dblock, please, let me know if this is a valid way for your fixing all occurrences of start_date_local ✌️

i will then implement my fix to all the other models/specs

dblock commented 2 years ago

Want to finish this @simonneutert?

simonneutert commented 2 years ago

okay, here's what I could come up with so far ...

Please, comment or hit the box if you are complying.

Good

[ ] I added tests and made correct times with zones a thing (i know, my code could still use a little touch up at this point, though)

Bad

[ ] running races lack a reference in time, start_date simply isn't a thing 💡maybe we should simply hint this in the docs? I never participated in a running contest, could you maybe get a new vcr record, so we may see if they fixed the start_date in the meantime?

Ugly

[ ] Photos do miss a created_at_local, it is probably an issue by itself, but could be solved similarly once we are fine with how this one turned out

dangerpr-bot commented 2 years ago

	1 Warning
:warning:	Unless you're refactoring existing code or improving documentation, please update CHANGELOG.md.

Here's an example of a CHANGELOG.md entry:

* [#39](https://github.com/dblock/strava-ruby-client/pull/39): Fixing stravas faulty start_date_local implementation - [@simonneutert](https://github.com/simonneutert).

Generated by :no_entry_sign: Danger

dblock / strava-ruby-client

Fixing Stravas faulty start_date_local implementation #39