Closed deuber closed 3 years ago
But note, I was unable to run 'bundle exec rake' without many "Style/FrozenStringLiteralComment" messages. I ignored this as my test ran without failure (see gear.yml).
Let's leave your rubocop problems aside, but this is because you're running a different version.
In a future PR let's upgrade rubocop by incrementing its version in Gemfile, and running rubocop -a
and rubocop --auto-gen-config
.
I don't see an update pushed here. The diff still shows the changelog problem and the curl comment.
sorry, try that again.
git add . git commit -m "making all up to date" [add-gear-field 6576145] making all up to date 2 files changed, 2 insertions(+), 4 deletions(-) git push origin add-gear-field -f
This looks good! Build is failing with a trivial error:
spec/strava/api/client/endpoints/gears/gear_spec.rb:25:4: C: Layout/TrailingBlankLines: Final newline missing.
379end
380
easy fix?
yes :), try that. I simply added newline after closing "end".
Merged, thank you 🥳
Successfully ran STRAVA_ACCESS_TOKEN=my_access_token rspec spec/strava/api/client/endpoints/gears/gear_spec.rb
But note, I was unable to run 'bundle exec rake' without many "Style/FrozenStringLiteralComment" messages. I ignored this as my test ran without failure (see gear.yml).
Strava::Api::Client#gear returns gear returns gear by id
Finished in 0.68283 seconds (files took 1.05 seconds to load) 2 examples, 0 failures