search

dblock / strava-ruby-client

A complete Ruby client for the Strava API v3.
https://code.dblock.org/2018/11/27/writing-a-new-strava-api-ruby-client.html
MIT License
97 stars 22 forks source link

Ensure that large IDs are not truncated #49

Closed dblock closed 2 years ago

dblock commented 2 years ago

Coming from https://github.com/node-strava/node-strava-v3/issues/125, ensure that IDs aren't truncated and/or are cast to a string when they cannot be parsed. All IDs here are just declared as property.

markstos commented 2 years ago

According to StackOverflow, Ruby has no limit so this should not be a problem, but it's good to add some test coverage for.

https://stackoverflow.com/questions/535721/ruby-max-integer#:~:text=Ruby%20automatically%20converts%20integers%20to,how%20big%20they%20can%20be.&text=If%20you%20are%20looking%20for%20the%20size%20of%20Fixnum%20objects,)%2C%20you%20can%20call%200.

dblock commented 2 years ago

@markstos care to contribute?

markstos commented 2 years ago

No, thanks. I stay busy enough with the Node Strava client.

dblock commented 2 years ago

FYI https://github.com/dblock/strava-ruby-client/pull/51 verified that this wasn't an issue in the library. Thanks @simonneutert!