dblock / strava-ruby-client

A complete Ruby client for the Strava API v3.
https://code.dblock.org/2018/11/27/writing-a-new-strava-api-ruby-client.html
MIT License
97 stars 22 forks source link

Ensures large ID aren't trucated #51

Closed simonneutert closed 2 years ago

simonneutert commented 2 years ago

hope this is what you guys discussed and would prove long ids being parsed correctly 🌻

simonneutert commented 2 years ago

I copied over the activity vcr record and tripled its ID πŸ€·β€β™‚οΈ

dblock commented 2 years ago

Right on. I would reduce the test to just the ID stuff so we don't have unnecessary garbage in there.

simonneutert commented 2 years ago

vscode formatter autocorrected the markdown (default settings, I didn't flavor or sth), if you don't mind, let's stick to the given convention.

dblock commented 2 years ago

vscode formatter autocorrected the markdown (default settings, I didn't flavor or sth), if you don't mind, let's stick to the given convention.

Do you mind reverting that? Just use another editor. There’s no need to change the entire changelog * to - really.

simonneutert commented 2 years ago

@dblock done

dblock commented 2 years ago

Ugh CI is not running again. Screen Shot 2022-03-09 at 12 49 38 PM

Maybe you have some cycles to do https://github.com/dblock/strava-ruby-client/issues/42. I can take care of it soon otherwise.

simonneutert commented 2 years ago

How can I be of service, I am new to CI πŸ™ˆ

dblock commented 2 years ago

How can I be of service, I am new to CI πŸ™ˆ

@simonneutert I wrote some ideas for steps in https://github.com/dblock/strava-ruby-client/issues/42#issuecomment-1063293778, lmk when/if you get stuck!

dblock commented 2 years ago

You should rebase this one and let's see CI run?

dblock commented 2 years ago

Fix CI, looks like rubocop -a will do.

dblock commented 2 years ago

Please see above for the error on danger. Changing all - vs. * breaks the changelog checker, revert that part pls.

dblock commented 2 years ago

Merged, thank you!

simonneutert commented 2 years ago

thank you for your patience. I learned a lot already πŸ™