Upgrade Faraday to >= 2.0

dblock / strava-ruby-client

A complete Ruby client for the Strava API v3.

MIT License

97 stars 22 forks source link

Closed schinery closed 2 years ago

schinery commented 2 years ago

Also includes:

Dropped support for Ruby 2.5 and 2.6
Added separate Gemfile.danger as danger currently uses Faraday 1.0
Updated rubocop to 1.3.0, which includes using ENV.fetch instead of ENV[], and removing the todo

Most of these changes were copied from the Slack Ruby Client PR done previously.

dblock commented 2 years ago

Thank you! Looks like danger needs a bit of work.

schinery commented 2 years ago

Thank you! Looks like danger needs a bit of work.

Copied over swagger-danger be mistake, should be good now.

dangerpr-bot commented 2 years ago

	1 Warning
:warning:	[DEPRECATION] `check` is deprecated. Please use `check!` instead.

Generated by :no_entry_sign: Danger

dblock commented 2 years ago

Merged, thank you!