search

dblock / strava-ruby-client

A complete Ruby client for the Strava API v3.
https://code.dblock.org/2018/11/27/writing-a-new-strava-api-ruby-client.html
MIT License
97 stars 22 forks source link

Rate limiting #61

Closed adamwolf closed 1 year ago

adamwolf commented 2 years ago

I'm trying to help with getting @simonneutert's rate limiting work for #11 over the finish line.

I'm handy with git, so feel free to ask me to rebase/squash/do whatever!

I'm not sure about all the choices I made handling the feedback from #50, especially the ResponseWrap/RaiseError thing.

Related:

dblock commented 2 years ago

@adamwolf Rebase this change so that it doesn't have any conflicts and get it to green, I'll take a look at the PR once it's there! Feel free to squash all the changes, but you don't have to.

adamwolf commented 2 years ago

I rebased and the tests are green locally. Github says it needs maintainer approval to run workflows since I'm a first-time contributor here.

dangerpr-bot commented 2 years ago
1 Warning
:warning: [DEPRECATION] check is deprecated. Please use check! instead.

Generated by :no_entry_sign: Danger

dblock commented 1 year ago

Thanks @simonneutert for finishing this up! See https://github.com/dblock/strava-ruby-client/pull/50.