Implements RateLimit for API Request/Response

dblock / strava-ruby-client

A complete Ruby client for the Strava API v3.

https://code.dblock.org/2018/11/27/writing-a-new-strava-api-ruby-client.html

MIT License

97 stars 22 forks source link

Implements RateLimit for API Request/Response #64

Closed simonneutert closed 1 year ago

simonneutert commented 2 years ago

took off where Adam left
replaces https://github.com/dblock/strava-ruby-client/pull/50

TODO

[x] check variable naming (especially reponse/request)
[x] UPGRADING.md with hints to classes and their API that replaced the current state
[x] reread relevant parts of README.md
[x] maybe some more tests for pagination and the internal API of newly created classes
[x] hint on RaiseResponseError
[x] Namespaced inheritance for the models class Achievement < Strava::Models::Response to me that's a case when explicit beats implicit

dangerpr-bot commented 2 years ago

	1 Warning
:warning:	[DEPRECATION] `check` is deprecated. Please use `check!` instead.

Generated by :no_entry_sign: Danger

dblock commented 2 years ago

Mark this as ready when you're done and I'll re-CR carefully.

simonneutert commented 1 year ago

@dblock found the time to rebase, finally 😓

I will need some help with fixing dangerbot though.

dblock commented 1 year ago

Thanks!

Did we mean to say fifteen_minute_ everywhere it says fiveteen_minute_? "Fifteen" is the correct spelling for 15.

The Danger TOC is complaining that you're missing the - [Strava::Api::Ratelimit public_methods](#stravaapiratelimit-public_methods) section. I would just say "The following properties are available on Strava::Api::Ratelimit and not make it a section. Also the way I typically fix the TOC is by copy-pasting the Danger output above on top of the TOC and making a new commit.

simonneutert commented 1 year ago

https://github.com/dblock/strava-ruby-client/actions/runs/3789352784/jobs/6443023965

@dblock that typo might have haunted me all my life 🤯 please take a look on the failed action, too. cheers

dblock commented 1 year ago

Grab the updated token from https://github.com/slack-ruby/slack-ruby-bot-server/pull/156/files

dblock commented 1 year ago

Thanks for contributing this @simonneutert! Want to help co-maintain this library? Maybe make the next release? Email me your rubygems username to dblock at dblock dot org and I'll add you everywhere if you're up for it.

dblock commented 1 year ago

We forgot to increment the version in version.rb to 1.0, please?

simonneutert commented 1 year ago

@dblock I am very sorry for the faulty version, don't know why it slipped my mind and the search.