Specific Error for file upload failures

dblock / strava-ruby-client

A complete Ruby client for the Strava API v3.

https://code.dblock.org/2018/11/27/writing-a-new-strava-api-ruby-client.html

MIT License

97 stars 22 forks source link

Specific Error for file upload failures #67

Closed simonneutert closed 1 year ago

simonneutert commented 1 year ago

Findings

strava uses background jobs for the file operations
query for status (polling like)
query show route of uploads contains all details

Doings

[x] adds webrick for ruby v3 support
[x] custom error class, ending with error by convention
[x] detection of error status on model instantiation via custom validation, raises new UploadFailError
[x] paragraph for the Error in README.md
[x] draft text for UPGRADING.md
[x] VCR record the "happy path" of an upload action
[x] Hint in UPGRADING.md because of breaking change

dangerpr-bot commented 1 year ago

	1 Warning
:warning:	[DEPRECATION] `check` is deprecated. Please use `check!` instead.

Generated by :no_entry_sign: Danger

simonneutert commented 1 year ago

I sticked with what was there, much cleaner with your suggestions now 👏

Let me think of a nicer way to handle the validation we definitely need for Upload when doing client.upload(some-id).

simonneutert commented 1 year ago

Overall this LGTM, cleanup, make it ready to merge?

let me fly over the remaining issues first, please. if there are some minor works, I'd like to have them in first before going v2.0.0

dblock commented 1 year ago

Overall this LGTM, cleanup, make it ready to merge?

let me fly over the remaining issues first, please. if there are some minor works, I'd like to have them in first before going v2.0.0

Cool. Also we could cut a 1.x branch and continue putting fixes there.