Drops support for `Activity` attribute `type`

dblock / strava-ruby-client

A complete Ruby client for the Strava API v3.

https://code.dblock.org/2018/11/27/writing-a-new-strava-api-ruby-client.html

MIT License

97 stars 22 forks source link

Drops support for `Activity` attribute `type` #68

Closed simonneutert closed 1 year ago

simonneutert commented 1 year ago

in favor of the new attribute: sport_type, see issue description: #62

dangerpr-bot commented 1 year ago

	1 Warning
:warning:	[DEPRECATION] `check` is deprecated. Please use `check!` instead.

Generated by :no_entry_sign: Danger

dblock commented 1 year ago

In semver you typically mark something as deprecated in a 1.x version, then remove it in 2.x. Since we had already loudly deprecated these earlier, I believe we want to remove them here. I this correct?

dblock commented 1 year ago

Merged. Btw @simonneutert you should work off a fork even though you maintain this now.

simonneutert commented 1 year ago

Will do for sure, I didn't know better, sorry.