search

dblock / vmwaretasks

C# VixCOM Wrapper Library & Tools
MIT License
59 stars 52 forks source link

Added some code to deal with deprecated constants in VixCom 1.11 #3

Closed mikewalker closed 12 years ago

mikewalker commented 12 years ago

Hi,

I added this to get around the problem with the constants that were removed in VixCom 1.11. It should also work with prior versions before the constants where removed. I wasn't using the feature but the removed constants was blocking the buid.

dblock commented 12 years ago

I would take this change if it were a bit more generic. Add another version of or extend VMWareVixHandle.GetProperty that supports a default when it's not available. This also needs a unit test retrieving a dummy property and making sure the default was returned.

dblock commented 12 years ago

Btw, since you're using Vix 1.11, I would like a cleaner pull request than #2 that does a full upgrade, with docs, etc. Also please don't forget to update HISTORY.md. Thanks!

mikewalker commented 12 years ago

Being a bit more generic is a good point, you never know when additional properties will get removed. :)

I'll take a look at cleaning it up a bit, add unit tests and update history.

mikewalker commented 12 years ago

Hi,

I was looking into updating the unit tests and have run into an issue. I have seen this with other projects but don't recall what the issue was. As far as I can tell all the dependancies are in place. Any ideas, I did try doing a x86 build rather than Any CPU incase that was it.

Could not load file or assembly 'Vestris.VMWareLibUnitTests, Version=1.7.629.0, Culture=neutral, PublicKeyToken=null' or one of its dependencies. The system cannot find the file specified.

Update: Problem solved

mikewalker commented 12 years ago

Closed in favor of new pull request on its own feature branch "Vix111".