dblodgett-usgs / hygeo

https://dblodgett-usgs.github.io/hygeo/dev/
Creative Commons Zero v1.0 Universal
6 stars 1 forks source link

Inconsistent application of COMID keys in crosswalk #29

Closed hellkite500 closed 3 years ago

hellkite500 commented 3 years ago

An entity with multiple COMIDs looks like:

"cat-X": {
    "COMID": ["000000", "11111111", "2222222"]
}

whereas one with only a single COMID is:

"cat-Y": {
    "COMID": "3333333"
}

In this latter case, the COMID should be a singleton list to keep a consistent schema, i.e.

"cat-Y": {
    "COMID": ["3333333"]
}
dblodgett-usgs commented 3 years ago

I wrote the JSON with auto_unbox = TRUE ... so you want auto_unbox = FALSE? https://github.com/dblodgett-usgs/hygeo/blob/master/vignettes/sugar_creek_refactor.Rmd#L224

hellkite500 commented 3 years ago

Don't need everything unboxed, just the "COMID". Not sure what it will do to things like site_no and outlet_COMID which really should be scalar values.

hellkite500 commented 3 years ago

Bumping this, still not fixed in latest release.