search

dblotsky / stringfuzz

Fuzzer and generator for string and regex problems in SMT-LIB 2.x format.
Other
20 stars 9 forks source link

Adding Ifaz's transformers #9

Closed FedericoAureliano closed 6 years ago

dblotsky commented 6 years ago

@FedericoAureliano thanks for making the second PR, and for merging the first one! I left a few small comments.

What do you think about adding command-line arguments to some of these transformers to be able to change their behaviour?

FedericoAureliano commented 6 years ago

Hey @dblotsky, I added command line arguments to both translate and multiply (and all transformers now have that capability).

FedericoAureliano commented 6 years ago

Hey @dblotsky! Sorry for the long delay! Ready to merge if you approve.

dblotsky commented 6 years ago

@FedericoAureliano I've left a few comments to be addressed still. Sorry for not noticing some of those things earlier!

FedericoAureliano commented 6 years ago

Hey @dblotsky, I think I've addressed the issues

dblotsky commented 6 years ago

@FedericoAureliano thanks for addressing them! Sorry, I had one small comment left. After that's fixed, the PR should be good to merge.

dblotsky commented 6 years ago

@FedericoAureliano looks good! I'm going to merge the PR. Is that ok?

FedericoAureliano commented 6 years ago

Sounds good!