User signin - Githubissues

dbm03 / cs2340-project-2

https://barrosodavid.github.io/cs2340-project-2/

1 stars 0 forks source link

User signin #11

Closed nekronos-gh closed 6 months ago

nekronos-gh commented 6 months ago

Please @barrosodavid , could you clean up all you added? I do not want to delete anything, since I do not know how it works and I do not want to break it.

Also guys (@barrosodavid @Naraja4), please check the following functionality:

You can sign In with email
You get redirected to StratupScreen
You get greeted with a welcome (After closing and opening the app)
You can log out by changing the user

dbm03 commented 6 months ago

Please @barrosodavid , could you clean up all you added? I do not want to delete anything, since I do not know how it works and I do not want to break it.

Also guys (@barrosodavid @Naraja4), please check the following functionality:

You can sign In with email

You get redirected to StratupScreen

You get greeted with a welcome (After closing and opening the app)

You can log out by changing the user

I just cleaned up unused classes and removed Android studio user configs from the repo, Please review changes

Naraja4 commented 6 months ago

Also guys (@barrosodavid @Naraja4), please check the following functionality:
* You can sign In with email

* You get redirected to StratupScreen

* You get greeted with a welcome (After closing and opening the app)

* You can log out by changing the user

Testing sign-in with development email, CANNOT log-in with an already existing account. When trying to log in with an email associated with the account, it leads to the register screen, making it unable to log in again. Says: 'Unable to register this email'. Logcat output states: Error creating user com.google.firebase.auth.FirebaseAuthUserCollisionException: The email address is already in use by another account.
If creating a new account, you get redirected and greeted with a welcome.
Opening and closing the app does trigger this welcome.
Log out button works by changing the user.

dbm03 commented 6 months ago

@nekronos-gh can you check this pls

nekronos-gh commented 6 months ago

Hey beautiful people @barrosodavid @Naraja4.

I have fixed the issue creating a new window with two options: log in and sign in. Could you check its working and validate this pull request? Thanks!

dbm03 commented 6 months ago

Checking it right now on Android emulator, I'll keep you updated

Naraja4 commented 6 months ago

Hello handsome @nekronos-gh ,

I have tested the app. Log-In works as expected. However I have 2 concerns:

When logging in, the welcome window is not shown, is this intended?
When exiting and entering again, the welcome window does not display the user name:

dbm03 commented 6 months ago

Also it should display "Sign up" instead of "Sign in" on the button that registers your user. I'll create a commit to fix this in 1 sec