Closed dbm03 closed 6 months ago
I know what the problem is. We disabled pushing into main, so the github actions bot is unable to push the formatting changes. I have no idea how to solve this...
I'm taking a look at these:
This one looks good, but I do not have the privileges to make this happen:
One solution could be to disable the formatting workflow when we're on the main branch.
The code should be formatted already when accepting the pull request from a different branch right?
This one looks good, but I do not have the privileges to make this happen:
Awesome, I'll add it to the repo
One solution could be to disable the formatting workflow when we're on the main branch.
The code should be formatted already when accepting the pull request from a different branch right?
Yeah, It should have been previously formatted before the pull request.
I prefer to disable the formatting in the main
branch, as the other solution requires making a new GitHub account or registering an organization
Sounds good
Let's keep it open until we are 100% sure it works
By now this should have been fixed
Describe the bug Formatting GitHub action fails when merging from a branch into main, when making a commit squash with formatted code into the previous commit.
To Reproduce Steps to reproduce the behavior:
Expected behavior Formatting workflow should be able to apply reformat to the previous commit
Screenshots