search

dbmdz / iiif-presentation-api

Java library implementing the IIIF Presentation API
MIT License
13 stars 8 forks source link

Change service deserialization to handle any service type #11

Closed skinsoft closed 7 years ago

skinsoft commented 7 years ago

Hello,

I am trying to add a search api service but the deserialization of the manifests for services was only processing "image" and "physdim" cases. As the image part of the deserialization did not had anything special, I transformed it into a more generic case.

What do you think about it ?

codecov-io commented 7 years ago

Codecov Report

Merging #11 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #11   +/-   ##
=========================================
  Coverage     54.86%   54.86%           
+ Complexity      250      249    -1     
=========================================
  Files            68       68           
  Lines           955      955           
  Branches         46       46           
=========================================
  Hits            524      524           
  Misses          405      405           
  Partials         26       26
Impacted Files Coverage Δ Complexity Δ
...l/jackson/deserializer/v2/ServiceDeserializer.java 92% <100%> (ø) 6 <0> (-1) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eb8ea67...76fe524. Read the comment docs.

jbaiter commented 7 years ago

Looks good to me, thank you!!