search

dbmdz / iiif-presentation-api

Java library implementing the IIIF Presentation API
MIT License
13 stars 8 forks source link

Supporting v2.1 of IIIF Presentation API #5

Open Eyal-R opened 7 years ago

Eyal-R commented 7 years ago

Hello, Do you have plans or intentions of upgrading the product to support the new v2.1 of IIIF Presentation API ( http://iiif.io/api/presentation/2.1/ ) which was released on May 2016?

Eyal

abollini commented 7 years ago

I'm also interested in the support of the new v2.1 Which is the best way to move this ahead? how to contribute? right now I need to support multiple services for manifest

datazuul commented 7 years ago

as we are using semantic versioning according to the specification version, version 2.1 and 2.0 should be "non breaking", meaning: 2.1 just adds new features/fields, no breaking changes.

so feel free to fork it an send a pull request with your changes. To change "service" to "services", you have to change code in the model maven modules: "iiif-presentation-api/iiif-presentation-model-api" and "iiif-presentation-api/iiif-presentation-model-impl"

Cheat how the list of metadata for example is implemented in CanvasImpl. Please make sure that afterwards the code in the other modules is still compiling and add junit-test if possible. Please adjust "set/getService" so that it still works (with the first element of the list).

datazuul commented 7 years ago

oh, just change existing code in package "de.digitalcollections.iiif.presentation.model.api.v2" as it is the package for all 2.x-versions

abollini commented 7 years ago

I have created the PR#6 to add support for multiple services. No ones were calling the set/getService method from the iiifResource interface so no need to proxy methods for backward compatibility. I don't like adding such things as they make the interface messy diverging from simple POJO

abollini commented 7 years ago

any feedback on that? have you checked the PR #6 ?

jbaiter commented 7 years ago

@abollini I did, can you make the small naming change that I suggested in the review?

abollini commented 7 years ago

done, I have updated the PR