dbmdz / iiif-presentation-api

Java library implementing the IIIF Presentation API
MIT License
13 stars 8 forks source link

Support multiple services as specified in the Presentation API v2.1 #6

Closed abollini closed 7 years ago

codecov-io commented 7 years ago

Codecov Report

Merging #6 into master will decrease coverage by 0.01%. The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #6      +/-   ##
============================================
- Coverage     54.44%   54.42%   -0.02%     
- Complexity      235      236       +1     
============================================
  Files            65       65              
  Lines           911      915       +4     
  Branches         45       45              
============================================
+ Hits            496      498       +2     
- Misses          388      390       +2     
  Partials         27       27
Impacted Files Coverage Δ Complexity Δ
...ons/iiif/presentation/model/impl/v2/RangeImpl.java 25.64% <100%> (+1.95%) 5 <0> (ø) :arrow_down:
...tation/model/impl/v2/AbstractIiifResourceImpl.java 85.71% <100%> (ø) 17 <2> (ø) :arrow_down:
...s/iiif/presentation/model/impl/v2/ServiceImpl.java 52% <33.33%> (-2.55%) 9 <1> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d5b7fd4...e80a73a. Read the comment docs.

abollini commented 7 years ago

I have revert the commit d4f9dc5 as adding support for multiple services everywhere change the serialization of the manifest and this break some tests other than most probably many client. The IIIF examples show just a single service for

with these changes I'm able to generate manifest like this one http://uvdemo.4science.it/manifest/hamlet

abollini commented 7 years ago

Hi, sorry I was unable to immediately apply the suggested changes and I have forget about that for a while... I have renamed the methods to reflect the plural of services and updated the relevant test so that the build success