search

dbmdz / iiif-presentation-api

Java library implementing the IIIF Presentation API
MIT License
13 stars 8 forks source link

Presentation API 2.1 : Adding "rendering" property to IIIF resources #7

Closed skinsoft closed 7 years ago

skinsoft commented 7 years ago

I tried to follow the same conventions as you, such as the javadoc comming from the IIIF spec. I've also added a "rendering" example in the manifest.json used for test to assert that it does not break the mapper (although it does not assert that the content has been deserialized).

Is it fine ?

Related to issues : #8 & #5

codecov-io commented 7 years ago

Codecov Report

Merging #7 into master will decrease coverage by 0.21%. The diff coverage is 45.45%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #7      +/-   ##
============================================
- Coverage     54.45%   54.24%   -0.22%     
- Complexity      235      240       +5     
============================================
  Files            65       67       +2     
  Lines           909      931      +22     
  Branches         45       45              
============================================
+ Hits            495      505      +10     
- Misses          387      399      +12     
  Partials         27       27
Impacted Files Coverage Δ Complexity Δ
...on/model/impl/jackson/mixin/v2/RenderingMixIn.java 0% <0%> (ø) 0 <0> (?)
...pl/jackson/v2/IiifPresentationApiObjectMapper.java 100% <100%> (ø) 3 <0> (ø) :arrow_down:
...tation/model/impl/v2/AbstractIiifResourceImpl.java 87.09% <100%> (+1.38%) 19 <2> (+2) :arrow_up:
...iiif/presentation/model/impl/v2/RenderingImpl.java 35.29% <35.29%> (ø) 3 <3> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d06e009...f11edb2. Read the comment docs.

jbaiter commented 7 years ago

Thank you! And sorry this took so long!