Error in manifest file should not lead to a 404

dbmdz / iiif-server-hymir

Hymir is a Java based IIIF Server. It is based on "IIIF Image API Java Libraries" and "IIIF Presentation API Java Libraries" projects (see https://github.com/dbmdz)

MIT License

27 stars 7 forks source link

Error in manifest file should not lead to a 404 #10

Closed VonUniGE closed 5 years ago

VonUniGE commented 6 years ago

If a manifest file contains an error, the request iiif/presentation/v2/1234567890/manifest return a 404.

Step to reproduce:

Edit one of your manifest file
Change "@type": "dctypes:Image" to "@type": "dctypes:Illustration"
Get the manifest iiif/presentation/v2/1234567890/manifest
Observe that a 404 is returned

Desired behavior: A more meaningful HTTP error should be returned such as 422 (Unprocessable Entity)

datazuul commented 5 years ago

we will throw an internal error 500 (and log error message). 422 is not applicable as it is a client error (unprocessable request content), see https://tools.ietf.org/html/rfc4918#page-78 will be part of upcoming 4.0.0 release