Redirection to canonical url is not optional

dbmdz / iiif-server-hymir

Hymir is a Java based IIIF Server. It is based on "IIIF Image API Java Libraries" and "IIIF Presentation API Java Libraries" projects (see https://github.com/dbmdz)

MIT License

27 stars 7 forks source link

Redirection to canonical url is not optional #15

Closed MarcAgate closed 6 years ago

MarcAgate commented 6 years ago

I have noticed that this redirection ( https://github.com/dbmdz/iiif-server-hymir/blob/master/src/main/java/de/digitalcollections/iiif/hymir/image/frontend/IIIFImageApiController.java#L113 ) is mandatory in Hymir code while the specs says:

Image servers MAY redirect the client to the canonical URI from a non-canonical equivalent. see http://iiif.io/api/image/2.0/#canonical-uri-syntax

it would be great to be able to choose using redirection or not.

jbaiter commented 6 years ago

This is now implemented on the master branch, just set this value in your application.yml:

custom:
  iiif:
    image:
      canonicalRedirect: false

MarcAgate commented 6 years ago

Great ! Thank you. Since we reference hymir server (v. 3.5.2) in our pom, could you update maven repo as well ?

jbaiter commented 6 years ago

@datazuul @morpheus-87 can you guys release 3.6.0? I don't have the signing keys on my laptop :-/