search

dbmdz / mirador-textoverlay

Text Overlay plugin for Mirador 3
https://mirador-textoverlay.netlify.com/
MIT License
50 stars 13 forks source link

Bug with manifest on onFragment #291

Open PonteIneptique opened 1 year ago

PonteIneptique commented 1 year ago

Hi there :)

I have been playing with the plugin in the last day, and something failed, probably because of a bad ALTO but I have stopped javascript for too long to be able to pinpoint more than a specific issue, which is https://github.com/IIIF-Commons/manifesto/issues/121

Basically, there seems to be an issue with Fragment, which could be caused downstream of this plugin or downstream of manifesto. I wanted you to know this :)

PonteIneptique commented 1 year ago

Hey :) manifesto.js was updated (4.2.17), unfortunately I am unable to use it as a fix while using your repo in NPM. Could you upgrade the dep / build ? :)

jbaiter commented 1 year ago

I just published 0.3.8 on npm, can you check if it fixes your problem?

PonteIneptique commented 1 year ago

Hey @jbaiter :) Yes it fixed the plugin issue but the code seems to be the same in the original mirador.js code (see the dirty fix I have to deploy: https://github.com/PonteIneptique/htr-light-viz-action/blob/main/dirty-fix.py )

This might be due to a parsing issue, or an ALTO having an incorrect line ?

jbaiter commented 1 year ago

Can you give me a sample ALTO that fails due to this bug?

PonteIneptique commented 1 year ago

I am gonna try to set up an example by next week, I am in slow mode since a couple of days and I am trying to get back in the game ^^