search

dbnschools / moodle-theme_fordson

Theme for Moodle 3.3+
43 stars 40 forks source link

Minor fix: undefined $PAGE->theme->settings->... #10

Closed hannaedelman closed 6 years ago

hannaedelman commented 7 years ago

Hello, please see if you can code review this patch and pull request it

dbnschools commented 6 years ago

Manually fixed. https://github.com/dbnschools/moodle-theme_fordson/commit/c09dad724268809a2daa6415e09e1223cdbee430

hannaedelman commented 6 years ago

Hello, thanks for the quick response! We still find this issue in many other undefined properties, such as $coursemanagementtoggle in /var/www/apps/moodle33/theme/fordson/classes/output/core_renderer.php on line 921$coursemanagementtoggle in /var/www/apps/moodle33/theme/fordson/classes/output/core_renderer.php on line 921 $showcourseadminstudents in /var/www/apps/moodle33/theme/fordson/classes/output/core_renderer.php on line 1149 ... and more, when debug mode is set for DEVELOPER , probably since we use php7 . actually I think this check should be done for all properties :-)