dbnschools / moodle-theme_fordson

Theme for Moodle 3.3+
43 stars 40 forks source link

Improvement: align completion icons on the left side of the screen #106

Open luiggisanso opened 4 years ago

luiggisanso commented 4 years ago

Hi Chris

I definitely love your theme but that's not objective... ;-)

But is it possible to change the alignment of the completion icons just in front of the activities/resources instead of at the end of the line?

I added this code in scss and it works: .section .activity .actions { position: relative; } .path-course-view li.activity span.autocompletion, .path-course-view li.activity form.togglecompletion { float: left; margin-left: -30px; margin-top: -30px; }

image

Thanks very for your great work.

dbnschools commented 4 years ago

I love this. Trust me, we would love to have the checkboxes at the beginning of the line. It is on my list to have it do that. Possibly by re-writing the renderer. I am not sure the best approach. If this css trick works I will consider using it in a future release. Please know that our schools are closed due to COVID-19. I am working from my basement. Out top priority is supporting our teachers working from home right now. I love your willingness to share these awesome improvements!!!

dbnschools commented 4 years ago

PS. Initial testing on my dev site looks really nice! I'll be honest, after so many years of seeing it on the right side it makes my brain hurt to see it on the left. lol. Great job. This looks like a winner with just a few minutes of testing.

luiggisanso commented 4 years ago

Yes I understand, good luck for supporting. We are all in the same case I think...

Cheers.

luiggisanso commented 4 years ago

PS WorkPlace have the left icon setting image

dbnschools commented 4 years ago

I saw some demos of Workplace last summer and I really like their interface and layout.

I think having it on the left is the way to go. I might build it into a toggle in Fordson settings to activate or not activate the CSS. Give people a choice.

If things slow down for me I will implement this for the next release.

luiggisanso commented 4 years ago

I might build it into a toggle in Fordson settings to activate or not activate the CSS. Give people a choice

I think it's the perfect choice !

dbnschools commented 4 years ago

Thank you. I think people will love this as an option.

luiggisanso commented 4 years ago

FYI Be carfull with Tiles Format

image

And it's only for manual completion

luiggisanso commented 4 years ago

Well...

With edit on... image

Hope you'll be able to check this better than me ;-)

Cheers.

luiggisanso commented 4 years ago

Ok just a temporary hack... (with indent)

image

// en mode édition on // .path-course-view.editing li.activity span.autocompletion img { float: left; margin-left: -110px; }

Really not perfect...

And fr tiles formt, it's the "margin-top: -30px;" which is too much...

Sorry, and good luck ;-)

Bye

luiggisanso commented 4 years ago

Hi Chris

Do you have some news about it ?

Cheers.

dbnschools commented 4 years ago

I am afraid I couldn't get it stable enough in all scenarios to include.

luiggisanso commented 4 years ago

no worries, I know it will work well one day ;-)