search

dbnschools / moodle-theme_fordson

Theme for Moodle 3.3+
43 stars 40 forks source link

Notice: Undefined property: stdClass::$showbacktotop #12

Closed nadavkav closed 6 years ago

nadavkav commented 6 years ago

Several minor code fixes for solving "Notice: Undefined property: stdClass:: ..." can be PR #10 Please review and see if you can integrate.

nadavkav commented 6 years ago

Ping @hannaedelman

dbnschools commented 6 years ago

OK. I'll take a look and merge this. I may just do it manually because I am pretty sure I have updated github since this was introduced. This will be in the 1.6.5 release. Although in my testing as long as the theme admin page had been saved then it doesn't give an error.

nadavkav commented 6 years ago

Bless you :smile: I think we are experiencing it because we use php7, and it might be a little bit more strict than earlier versions.

nadavkav commented 6 years ago

We also get a lot of those messages on the frontpage layout, only when debug mode is set for DEVELOPER.

dbnschools commented 6 years ago

Fixed. https://github.com/dbnschools/moodle-theme_fordson/commit/c09dad724268809a2daa6415e09e1223cdbee430

dbnschools commented 6 years ago

I fixed each of the layout files. I saw it wasn't limited to the 2columns file.

dbnschools commented 6 years ago

New versions are now published on Moodle.org.

nadavkav commented 6 years ago

Bless you! (btw, amazing theme!)