search

dbnschools / moodle-theme_fordson

Theme for Moodle 3.3+
43 stars 40 forks source link

Navdrawer options do not seem to work as expected in Moodle 3.11.10 #157

Open sgodbehere01 opened 1 year ago

sgodbehere01 commented 1 year ago

Hi there,

On Moodle 3.11.10 using the latest compatible version of Fordson (2021072100) it appears that the "navdrawer" does not show by default even when "Show Navdrawer" is ticked and "Nav Drawer Closed by Default" is unticked in the "Menu settings".

Also upon opening the navdrawer and navigating to a different page it closes again so it does not appear to be saving the "user preferences" for this either.

We want the navdrawer to show by default, so for any others having this issue this can be temporarily fixed by going to /var/www/moodle/theme/fordson/layout/ and changing all of the files inside from:

$hasfhsdrawer = isset($PAGE->theme->settings->shownavdrawer) && $PAGE->theme->settings->shownavdrawer == 1; if (isloggedin() && $hasfhsdrawer && isset($PAGE->theme->settings->shownavclosed) && $PAGE->theme->settings->shownavclosed == 0) { $navdraweropen = (get_user_preferences('drawer-open-nav', 'true') == 'true'); } else { $navdraweropen = false; }

to

$hasfhsdrawer = isset($PAGE->theme->settings->shownavdrawer) && $PAGE->theme->settings->shownavdrawer == 1; if (isloggedin() && $hasfhsdrawer && isset($PAGE->theme->settings->shownavclosed) && $PAGE->theme->settings->shownavclosed == 0) { $navdraweropen = (get_user_preferences('drawer-open-nav', 'true') == 'true'); } else { $navdraweropen = true; }

Which causes the navdrawer to show by default. That does not allow users to hide the drawer and keep it hidden however, it will always show for everyone.

Let me know if you have any questions or are unable to replicate on the same Moodle and plugin versions.

Thanks

Sam