dbnschools / moodle-theme_fordson

Theme for Moodle 3.3+
42 stars 40 forks source link

Fix breadcrumbs in RTL mode #38

Closed nadavkav closed 5 years ago

nadavkav commented 6 years ago

When using styled breadcrumbs in RTL mode, the styles "pointers/arrows" between the hierarchy breaks. Attaching LTR and RTL images to illustrate the issue: RTL: image001 And LTR: image002

To fix it, I added the following code to the RAW SCSS inside the theme's Color management tab.

.dir-rtl ul.breadcrumb li:after{
  transform: scale(.707) rotate(315deg);
  -webkit-box-shadow:  -3px -3px 0 1px #fff, -2px -3px 0 2px #fff;
  box-shadow: -3px -3px 0 1px #fff, -2px -3px 0 2px #fff;
}

Please review this fix as see if you can add it to the (amazing!) theme you made, or maybe solve it more elegantly at the proper place inside the scss files.

Best, Nadav

dbnschools commented 6 years ago

This should be completed in update 10 to Fordson. Please test and confirm it works as desired. I do not have a test environment for RTL.

nadavkav commented 6 years ago

Thank you, I will.