Closed bollycanuk closed 5 years ago
It does NOT happen with the Moodle 3.6 Boost theme.
I've noticed it too on my dev site. Once we get closer I will have to see what all they changed and try to fix it.
Here's what I've got so far and it seems to help fix up some things:
#page-wrapper {height:auto;}
#region-main {
border: 0;
padding: 1.25rem;
background-color: transparent;
}
Yup, that seems to fix it.
many thanks! Derek
On Tue, 2 Oct 2018 at 10:38, Dearborn Public Schools < notifications@github.com> wrote:
I've noticed it too on my dev site. Once we get closer I will have to see what all they changed and try to fix it. Here's what I've got so far and it seems to help fix up some things:
page-wrapper {height:auto;}
region-main {
border: 0; padding: 1.25rem; background-color: transparent;
}
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dbnschools/moodle-theme_fordson/issues/41#issuecomment-426298942, or mute the thread https://github.com/notifications/unsubscribe-auth/AInxEkql-b2SoNkLql5s48tmzpq6Xyt9ks5ug3pvgaJpZM4XEGnL .
While I gave you a quick fix we have more to go. I have a working Moodle 3.6 copy that fixes this as well as some classes that were changed in core.
Try out this...
fordson_initialrelease_Moodle36.zip
The big change in the zip I attached was to move the footer placement in the actual template. It was outside the page-wrapper div and I moved it inside that and the issue went away. That will be the permanent fix.
I know the version 3.6 release is still a month away but I've been running Moodle 3.6 alpha for a while. The current Moodle 3.5 Fordson v3.5 release 3 update 12 (2018100100) theme works really well with it EXCEPT that the footer tends to scroll up with the page. What is really weird is that if I zoom my browser in or out, the footer position is always at the "bottom" of the portion of the page that is first visible - i.e. the home position. But the footer still scrolls up from that initial position when I scroll down the page.
Here is a page when I first load it:
Here is the page when I scroll down. Footer follows the scrolling
Now if I zoom out to 80% the top portion looks like it should
But scrolling down, the footer still scrolls up, albeit in a different vertical position.
cheers, Derek