search

dbnschools / moodle-theme_fordson

Theme for Moodle 3.3+
43 stars 40 forks source link

"Site announcements" string is not translated #45

Closed ianni67 closed 5 years ago

ianni67 commented 6 years ago

As per subject: the string "Site announcements" in the home page is not translated when I change language to italian. All other strings are correctly translated. The "sitenews" string is present in the the language pack.

I really like this theme but could not find a solution to this issue.

dbnschools commented 6 years ago

I will take a look and get this fixed. Do you have a screenshot of the exact place the text isn't translating? Also, what version of Moodle and Fordson theme are you using?

ianni67 commented 6 years ago

Thank you for your prompt reply. Moodle: $release = '3.5.2+ (Build: 20181023)' Fordson: 3.5 (downloaded and installed abt one week ago). screenshot_20181103_095135-01

dbnschools commented 6 years ago

Thanks for the image. That language string is translated by Moodle and part of core. It is not generated at the theme level. This message will not change unless the user selects another language from Moodle and the proper language is set at the site/user level.

ianni67 commented 6 years ago

This is the only string that does not change when the user selects another language. I already tried everything I know to select a language. Would you, please, elaborate a little bit more on "the user selects another language from Moodle"? Thank you very much for your kind help

dbnschools commented 6 years ago

I have searched throughout my theme to find that as a text string or just hard coded and I cannot find anything. Does it do the same thing with the Boost theme?

ianni67 commented 6 years ago

I just checked. Indeed it does the same thing with the Boost theme. It must be an issue with my configuration, though it is a fresh install and I cannot figure out what it may be. Sorry, I did not realize it was a moodle-wide issue in my installation. Thank you for your help. I suppose that now the issue can be closed.

dbnschools commented 6 years ago

It might be a bug with Moodle core. It's possible that that string wasn't translated.

ianni67 commented 6 years ago

The corresponding string in the italian "lang" dictionary is present. The problem is that it is not picked up by moodle. Looks like the string "Site announcements" is hardwired somewhere in moodle core, which is obviously not possible (or it is a very stupid bug).

ianni67 commented 6 years ago

I eventually stumbled upon this page, describing exactly the same issue: https://moodle.org/mod/forum/discuss.php?d=353045 Looks like it is a long-living problem in moodle. Never solved.

dbnschools commented 5 years ago

OK. Looks like this is a Moodle issue and not the theme. Closing.