search

dbnschools / moodle-theme_fordson

Theme for Moodle 3.3+
42 stars 40 forks source link

Moodle 3.4.6 Can not Login due to missing LoginToken #48

Closed ruddj closed 5 years ago

ruddj commented 5 years ago

Moodle 3.4.6 introduced a requirement that all login forms have a logintoken attribute to prevent automated logins. https://docs.moodle.org/dev/Login_token

As Fordson 3.4 v1.7 is missing this line, after performing the upgrade users are unable to login.

This can be easily fixed by adding <input type="hidden" name="logintoken" value="{{logintoken}}"> after lines 117, 162, 227, 270, https://github.com/dbnschools/moodle-theme_fordson/blob/moodle34/templates/core/login.mustache#L227

dbnschools commented 5 years ago

I am backporting the fix for Moodle 3.5.3 and will have a new version for 3.4 up soon. Moodle.org is where I'll be publishing the fix. Moodle.org was having an issue with uploading new plugins yesterday. I reported it and they said they would fix the issue. should have it ready to go today.

ruddj commented 5 years ago

Thank you. I tried to create a backport with pull request, but I could have easily missed things.

ruddj commented 5 years ago

Will you be updating the GitHub moodle34 branch in addition to posting on moodle.org?

dbnschools commented 5 years ago

I pushed the changes I made to the Moodle34 branch.

ruddj commented 5 years ago

Thank you.