search

dbnschools / moodle-theme_rebel

A radical Boost-based theme for Moodle LMS.
3 stars 3 forks source link

PHP error #8

Closed n000x closed 3 years ago

n000x commented 3 years ago

Notice: Undefined property: stdClass::$showonlygroupteachers in /home/u721446128/domains/url-of-staging-moodle/theme/rebel/classes/output/core_renderer.php on line 938

dbnschools commented 3 years ago

I will have a fix out shortly. The desired outcome is that when a student views their course dashboard they only see the teacher associated with their group.
https://github.com/dbnschools/moodle-theme_rebel/blob/2d4e2a0a3a7aa8082b6d4e3375f2d0c28774b1a1/classes/output/core_renderer.php#L938 Remove everything after the && " && $PAGE->theme->settings->showonlygroupteachers == 1"

dbnschools commented 3 years ago

In the next release, 1.7.2, I will have the " && $PAGE->theme->settings->showonlygroupteachers == 1" removed so that it will just show the student the teacher associated with them in their group.

n000x commented 3 years ago

It will be awesome if the theme is as mobile compatible as Adaptable theme which tucks the right column into a drawable sidebar on mobile browsers instead of showing right sidebar at the bottom of the page.

Kudos for the great work! Appreciate it.

On Thu, Dec 17, 2020, 8:04 PM Dearborn Public Schools < notifications@github.com> wrote:

In the next release, 1.7.2, I will have the " && $PAGE->theme->settings->showonlygroupteachers == 1" removed so that it will just show the student the teacher associated with them in their group.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dbnschools/moodle-theme_rebel/issues/8#issuecomment-747474726, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASDES2S6YHLHSJ7WIKZ7GZLSVIJITANCNFSM4UYQHQ6A .

dbnschools commented 3 years ago

That's a great idea.
We are going to limit how much development we do outside of what Moodle already provides in core. We tried this same approach with Fordson and it got away from us and then there were features and stuff everywhere which is difficult to maintain when the core keeps changing. I think we are going to stay small and nimble with this theme to focus on a very simple user interface without hiding anything from the user.

n000x commented 3 years ago

The idea behind Rebel and keeping this simple is what attracted me to this project. I would like to contribute once I get some free time.

My suggestion is on-line with Rebel philosophy. Many of my students access the lms on Mobile devices. Almost all themes clutter the small display and break down right sidebar at the bottom of the page. I liked how 'Adaptable theme' tucks in the top and right sidebar into side menu leaving only central content column on the screen.

If somehow that can be combined with Rebel philosophy of keeping things straightforward, it will make it best theme for use on Mobile browsers.

On Thu, Dec 17, 2020, 8:44 PM Dearborn Public Schools < notifications@github.com> wrote:

That's a great idea. We are going to limit how much development we do outside of what Moodle already provides in core. We tried this same approach with Fordson and it got away from us and then there were features and stuff everywhere which is difficult to maintain when the core keeps changing. I think we are going to stay small and nimble with this theme to focus on a very simple user interface without hiding anything from the user.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dbnschools/moodle-theme_rebel/issues/8#issuecomment-747499937, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASDES2QUUYBZSD7Z4GPCPITSVIN6VANCNFSM4UYQHQ6A .