search

dboehmer / coocook

👨‍🍳🦉 Web application for collecting recipes and making food plans
https://coocook.org/
Other
11 stars 2 forks source link

No tests for Controller::Meal #114

Closed moseschmiedel closed 3 years ago

moseschmiedel commented 4 years ago

At the moment I can write anything dumb, like for example die in Controller::Meal and the tests don't cover it and everything compiles fine.

dboehmer commented 4 years ago

@moseschmiedel You mean adding a die() inside any action methods, don’t you? Any compile time errors or code that is run at startup time will make the application fail and should definitely be covered by compile.t and 01app.t.

dboehmer commented 4 years ago

@moseschmiedel Thank you for raising this issue! :+1:

Adding a simple list of GET requests increased our test coverage by +9%.

Are you already satisfied with this test? What else do you require?

dboehmer commented 3 years ago

@moseschmiedel still waiting for a reply :smile:

moseschmiedel commented 3 years ago

I wrote some tests for the full lifecycle of meals.