search

dboehmer / coocook

👨‍🍳🦉 Web application for collecting recipes and making food plans
https://coocook.org/
Other
11 stars 2 forks source link

Offset handling #124

Closed moseschmiedel closed 3 years ago

moseschmiedel commented 3 years ago

Yeah, I think we can merge this into master.

dboehmer commented 3 years ago

We discovered new TODOs together:

Do not display the offset as virtual dish in print view.

moseschmiedel commented 3 years ago

We discovered new TODOs together:

* [ ]  display offset in list of dishes on purchase list **print view**

* [x]  remove `ca.` in print view

* [x]  display `+` or `-` icon after article name in print view if offset (`+` for positive offsets)

* [ ]  #109 (this PR can be completed without this)

Do not display the offset as virtual dish in print view.

How should the offset be displayed in the print view? Should we introduce a new column for it?

dboehmer commented 3 years ago

Did you realize that these subtasks were solely for the print view? I think they should describe exhaustively what needs to be changed. If anything particular is unclear please ask more pricesely :stuck_out_tongue:

moseschmiedel commented 3 years ago

Yes I realized, that these tasks were for the print view. What made me think was, that in the checklist it is written, that the offset should be displayed in the list of dishes, but underneath the checklist it is written that the offset should not be displayed as a virtual dish, so I wondered how I should display the offset in the list of dishes, when it should not look like a virtual dish?

dboehmer commented 3 years ago

Yes I realized, that these tasks were for the print view. What made me think was, that in the checklist it is written, that the offset should be displayed in the list of dishes, but underneath the checklist it is written that the offset should not be displayed as a virtual dish, so I wondered how I should display the offset in the list of dishes, when it should not look like a virtual dish?

Resolution: we display the offset in the print view as well and wait for user feedback on how to change that.

Advantages: