dboehmer / coocook

👨‍🍳🦉 Web application for collecting recipes and making food plans
https://coocook.org/
Other
11 stars 2 forks source link

Copy styling of "general information" inputs from recipe editor to dish editor #130

Open dboehmer opened 3 years ago

dboehmer commented 3 years ago

Code should not be shared between both pages because there are slightly different inputs.

Please wait for branch bootstrap to be merged in master and base your work on top of this.

rico-hengst commented 3 years ago

Current issue is realized.

About wording in template ''ingredients_editor.tt". It should be noted, that the template ''ingredients_editor.tt" is used in

So the form and the button "Update Recipe" in the Ingredients panel appears in both templates. The user of the dish editor will be confused if the phrase "Update Recipe" is used, .... maybe.

dboehmer commented 3 years ago

Current issue is realized.

Thank you for taking care of this!

About wording in template ingredients_editor.tt. It should be noted, that the template ingredients_editor.tt is used in

  • source template and
  • target template.

So the form and the button "Update Recipe" in the Ingredients panel appears in both templates. The user of the dish editor will be confused if the phrase "Update Recipe" is used, .... maybe.

Very good point! I’ve just pushed a fix. Do a quick git pull before you continue work:-)

Let’s keep this issue open until it’s merged into master.