dboehmer / coocook

👨‍🍳🦉 Web application for collecting recipes and making food plans
https://coocook.org/
Other
11 stars 2 forks source link

Warnings about vertical whitespace for email sents with a long subject #139

Open dboehmer opened 3 years ago

dboehmer commented 3 years ago

For an example see https://travis-ci.org/github/dboehmer/coocook/jobs/752858214

t/change_password.t ........... 2/53 replaced vertical whitespace in Subject header with space; this will become fatal in a future version at /home/travis/perl5/perlbrew/perls/5.30.3/lib/site_perl/5.30.3/Catalyst/View/Email.pm line 396.
replaced vertical whitespace in Subject header with space; this will become fatal in a future version at /home/travis/perl5/perlbrew/perls/5.30.3/lib/site_perl/5.30.3/Catalyst/View/Email.pm line 396.

@moseschmiedel already inspected this and filed https://github.com/dhoss/catalyst-view-email/issues/15

Looking at https://github.com/dhoss/catalyst-view-email/issues/10 it seems the current maintainers will probably not take care of this.

dboehmer commented 3 years ago

A minimal test for this that runs faster than the test suite:

use strict;
use warnings;

use lib 't/lib';
use Test::Coocook;
use Test::Most;

my $t = Test::Coocook->new;

$t->get_ok('/settings');
$t->login_ok( 'john_doe', 'P@ssw0rd' );
$t->submit_form_ok( { with_fields => { new_email => 'foo@example.com' } } );
note $t->emails->[0]{email}->as_string;
done_testing;
dboehmer commented 3 years ago

That is not exactly what we wanted:

image