search

dboehmer / coocook

👨‍🍳🦉 Web application for collecting recipes and making food plans
https://coocook.org/
Other
11 stars 2 forks source link

Remove jQuery #155

Closed dboehmer closed 2 years ago

dboehmer commented 3 years ago

We’re now using Bootstrap and with modern Javascript jQuery is told to be not necessary anymore. We’ve probably have a total of 155 lines of jQuery code:

$ ack '\$\(' root/static/js/ -l | xargs wc -l
  11 root/static/js/article/edit.js
  47 root/static/js/recipe/import/preview.js
  44 root/static/js/user/register.js
  53 root/static/js/script.js
 155 total
tjfoerster commented 2 years ago

@dboehmer We are using Boostrap 4 which requires jQuery. So we should upgrade to Bootstrap 5. This also gives us new possibilities for a modern ui. What do you think?

https://getbootstrap.com/docs/5.0/migration/

dboehmer commented 2 years ago

@dboehmer We are using Boostrap 4 which requires jQuery. So we should upgrade to Bootstrap 5. This also gives us new possibilities for a modern ui. What do you think?

https://getbootstrap.com/docs/5.0/migration/

Upgrading Bootstrap sounds good :+1: Especially if that removes a dependency on jQuery! Can you apply that and test it? I think Git history for the bootstrap branch should show which pages very touched for Bootstrap.