dboehmer / coocook

👨‍🍳🦉 Web application for collecting recipes and making food plans
https://coocook.org/
Other
11 stars 2 forks source link

Resp #88

Closed rico-hengst closed 5 years ago

rico-hengst commented 5 years ago

Modifications

Add responsible design / first step, see also https://github.com/dboehmer/coocook/issues/81

dboehmer commented 5 years ago

🎉, our first Pull Request from a non-team member! Thank you @rihengst for your efforts!

I checked out your branch and took a look at it. I find the the collapsing nav menu very cool. Some design changes like the boxes around My Projects on the homepage look impressing but very much like GitHub—I am not sure if this fits our design "roadmap" (we have no official roadmap but @cncpl and @ChristinaSi who do most of our design work).

As you can see on this PR's page on GitHub (or when trying to git merge upstream/ux) it has merge conflicts with the 'ux' branch. You're probably doing double-work or wasting time in conflicting edits until you rebase your work on top of current dboehmer/ux.

Thanks for sharing your edits on GitHub. How far are you with your edits? You still want to make some tweaks, don't you?

Some questions that came to my mind:

I still invite you to contribute smaller PRs like fixing the README for a start. I'd be very happy to merge that.

ChristinaSi commented 5 years ago

Dear @rihengst, could you please stop your work and visit a meeting of our team first or at least ask what is going on before doing some random changes that probably don't fit into our current timeline? I appreciate your participation but that is not very helpful to do something without asking first.

@dboehmer made some suggestions that you can start with.