search

dbordak / fmenu-rofi

fmenu modified for use with rofi
GNU General Public License v2.0
3 stars 1 forks source link

Segfault #2

Open Phyks opened 8 years ago

Phyks commented 8 years ago

Hi,

When I run this script in combi mode, I get a segfault.

% rofi -modi "combi" -show combi -combi-modi "window,run,ssh,fm:/home/phyks/.rofi/fmenu-rofi/fmenu-rofi"
zsh: segmentation fault (core dumped)  rofi -modi "combi" -show combi -combi-modi

Is it expected?

Thanks!

Phyks commented 8 years ago

After some checks and discussions on #gmpc@freenode, we found that is was due to non-UTF-8 characters handling in rofi. If some files on the system have non-UTF-8 characters, rofi will crash in combi mode (but only in this mode), after starting to filter. This is reproducible on Arch, but may not be on other systems.

Minimal example to reproduce is echo -e '\xF0'|rofi -dmenu. Not sure if it is fmenu-rofi's job to sanitize the string or rofi's job.