sebasmonia
commented
5 years ago I got it working by changing telephone-line-separator-render-image to this:
(cl-defmethod telephone-line-separator-render-image ((obj telephone-line-separator) foreground background)
"Find cached pbm of OBJ in FOREGROUND and BACKGROUND.
If it doesn't exist, create and cache it."
(let* ((height (or telephone-line-height (frame-char-height)))
(hash-key (format "%s_%s_%s" background foreground height)))
;; Return cached image if we have it.
(or (gethash hash-key (oref obj image-cache))
(puthash hash-key
(telephone-line-propertize-image
(telephone-line--create-pbm-image
(telephone-line-separator-create-body obj)
background foreground))
(oref obj image-cache)))))but now I get a small render defect in one of the monitors, see the attach.
(Also I think I should use something else to get the height, there's already a method define in utils to get the height but I was just testing :))
dbordak
I have monitors with different resolutions, if I let Windows adjust the DPI there's blurry text in at least one of them. Instead I have a hook that changes the frame font size depending on the current monitor.
Seems like telephone-line can't adjust correctly to the change. I think it might be related to the cache for separators, as if I move the frame to another screen without splitting it then the inactive mode-line renders with the minimum height, but if I split first then both active and inactive look the same size.
I tried making the height part of the image cache key but that didn't quite work. If you give me a clue what could be causing this I can try to submit a PR.