sebasmonia
commented
5 years ago Since I made the image cache changes in the same branch as the segments I couldn't submit it in a separate PR, The last 2 line commit will solve #103.
Open sebasmonia opened 5 years ago
sebasmonia
commented
5 years ago Since I made the image cache changes in the same branch as the segments I couldn't submit it in a separate PR, The last 2 line commit will solve #103.
dbordak
commented
5 years ago Oh, hey, I sorta forgot about this. I'll look over it now
sebasmonia
commented
5 years ago Will re-submit when I get a chance splitting the region & position segments.
BTW, I suggested in the original issue having a page in the GH wiki for segments. maybe? a few of these are relatively specific or small enough that they could very well be part of such a page and don't pollute the base package with so many small segments.
dbordak
commented
5 years ago I'm going to just commit the height in the hash key thing on its own since that's a pretty big feature.
Plain buffer name: the standard buffer name has a minimum width that I didn't like. I doubt on this segment, I guess the regular buffer-name one could receive a parameter to indicate the padding.
VC without back end: No point in seeing "Git" in all buffers :) I also removed the character indicators for modified, not added, etc. I think this could be renamed "vc-branch-only" to reflect the intent more accurately, but again, could be an argument in the existing vc segment.
Position + region size: I really like having the position only, as I don't care about the size of the buffer, or the "bottom", "all", etc. indicators. I added on top of it the region size, I know other modeline packages have it, so it must be ok, but can't help thinking in a big enough region counting lines and chars can be too slow.