search

dbordak / telephone-line

A new implementation of Powerline for Emacs
GNU General Public License v3.0
550 stars 51 forks source link

Use built-in faces in flycheck-segment. #76

Closed ogdenwebb closed 6 years ago

ogdenwebb commented 6 years ago

To let the user custom themes simple override those colors, because Emacs built-in colors don't fit nice into non-default Emacs themes.

dbordak commented 6 years ago

You probably don't want to use the built-in faces for this since it'd mean you'd need to override them to change the mode-line, when they're used in a whole lot of other places. Rather, you should make a telephone-line-{warning,error} that can, optionally, inherit those.

dbordak commented 6 years ago

(I had originally done this when I was writing the segment, but realized that above problem since my theme uses underlining on the error face)

ogdenwebb commented 6 years ago

Hm. Then can we simple inherit error/warning faces and disable face properties here? Also I like the idea with telephone-line-{warning,error} faces.

dbordak commented 6 years ago

Oh, just inherit whatever warning/error's foreground color is? yeah, that could work too.

dbordak commented 6 years ago

oops, just noticed you were still committing stuff as I merged. Everything good? It is as far as I can see.

ogdenwebb commented 6 years ago

Yeap, I've pushed the last commit almost in the same time with your merge. :tada: Besides I have to pay more attention while my changes next time. :/ Thanks you.